adding VDMS retriever and test - The VDMS retriever and test are implemented in this PR. PLEASE NOTE: The input for retriever is EmbedDoc and return is SearchedDoc (these types may need to be updated for service integration) #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
avinashkarani
suggested changes
Aug 13, 2024
There was a problem hiding this comment.
Hi @arijit-intel, please update Dataperp component to support data ingestion to VDMS https://github.com/opea-project/GenAIComps/tree/main/comps/dataprep. This will help use case to easily take advantage of VDMS.
…iever merge remote-tracking branch
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Merge remote-tracking branch 'origin/sameh-retriever' into sameh-retriever
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
@chensuyue can you please tag this PR with 'V0.9' Milestone |
|
submitted a new PR for the feature |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.